Remove sljf4j-nop logger to avoid swallowing logs#16
Open
transducer wants to merge 1 commit intoduct-framework:masterfrom
Open
Remove sljf4j-nop logger to avoid swallowing logs#16transducer wants to merge 1 commit intoduct-framework:masterfrom
transducer wants to merge 1 commit intoduct-framework:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi James,
With the
slf4j-nopincluded, in projects requiringduct/module.weball logs are swallowed when used in combination withduct.logger.clojure, clojure.tools.logging and Logback.The way to avoid that is by explicitly excluding this dependency. E.g., in
project.clj:I don't know what the reason was to add
slf4j-nop(maybe it is to remove logging of Jetty or other type of:duct.server/http), so maybe this PR needs some changes to re-add that behaviour if so desired.Kind regards,
Erwin